WIP: Blocker #1 - Agent Discovery Zone Isolation #7

2026-10-19T09:41:00-05:00

lussierj commented

2026-10-19 09:41:00 -05:00

Legacy discovery, summary refresh and CSV imports could select the wrong inventory record when Zones shared an IP, accept stale telemetry, or bypass control-board replacement authorization. This change binds authenticated Agent discovery, review, enrichment and telemetry to current server Agent/Zone authority and exact inventory identity, with atomic auditing and preserved history.

Blocker #1 application-security audit: PASS.
Production deployment: NOT APPROVED.

Scope:

Use stable observation IDs/versions, reconcile identity evidence and reject stale ownership or routing. Revalidate enrichment at queue claim and target resolution. Propagate inventory proofs through Windows polling clients and render untrusted Agent Control data as text.
Return HTTP 410 for direct/range discovery, local scheduled/manual known-miner refresh and one/bulk legacy summary writers in both Hub and non-Hub modes, including internal aliases and scheduler callers. Rejection precedes device I/O and mutation.
Keep CSV metadata imports available using exact Miner ID, current MAC, unambiguous serial, or IP plus explicit Zone. Reject conflicting identifiers and ambiguous IP fallback; commit metadata and actor-attributed audit together, with whole-import rollback on denial/audit failure.
Preserve Stage A physical-command containment. Include no migrations, Docker/build-context, schema-compatibility, system-health or unrelated control changes.

Independent evidence on this exact tree:

141 focused PostgreSQL/registered-HTTP tests passed, including real concurrency/lock waits, actual audit privilege-denial rollback, ownership changes, enrichment routing and historical preservation.
Chromium stored-injection/stable-action/retirement-error checks passed. Linux PowerShell 7.4: 12 discovery, 165 containment and 2,444 diagnostic checks passed.
Credential transition/enrollment passed; the full legacy-retirement migration fixture passed, with 8 real-auth passes and 4 intentional case-specific skips. Populated head upgrade preserved all 47 public tables.
Broad source/service suite: 72/74 passed. Both failures reproduce on the unchanged approved baseline; assertions remain unchanged:
- AgentEnrichmentIsolationSourceTests.test_legacy_config_remains_explicitly_legacy_only
- AgentSourceContractTests.test_deployment_preserves_local_state_and_registers_established_tasks

Operational compatibility and release gates:

Authenticated Agent observation/review and inventory-bound polling replace local discovery/summary refresh. Server-only installations have no local fallback; reachability-only scanning remains.
Automatic/public IP rebinding for an existing miner is unavailable. Changed-IP observations fail closed; a separately authorized address-rebinding workflow is required.
Unsupported old Agent payloads require coordinated upgrades. Native Windows PowerShell 5.1/SYSTEM and mixed-version operation, actual deployed database-role privileges and fleet-scale lock throughput still require release validation.
Verified old-Agent network fencing and stop/drain/upgrade/cutover validation remain required. Cached commands cannot be revoked solely by server cancellation. Physical-device identity binding and Blocker #3 Stages B-E remain outside this change.

Review identity and references:

Source: codex/review-07-discovery-isolation (proposed); target: codex/review-06-stage-a-containment.
Exact parent: e898f283ab0fc21bac77b63db1c4a9ad35e21562; tree: cf863aadc9019aefcdec3ba1dd3880619f4f6561.
Patch SHA-256: 0d2b2b03ef24c966e1ec633e96b4e8f3c5f37881802c25004f3fa42a012cdc9f.
Boundary: 26 files, 12 added / 14 modified / 0 deleted; +3,798 / -4,092 lines with minimal or histogram diff.
Independent PASS report on review host: /tmp/minerops-blocker1-reaudit.83ak6lwx/security-reaudit.txt; verdict: /tmp/minerops-blocker1-reaudit.83ak6lwx/verdict.json.
Corrected patch on review host: /tmp/minerops-blocker1-remediation.dhgyq25j/blocker-1-review.patch.
The frozen in-tree review notes predate the subsequent independent PASS; the report and verdict above record the completed re-audit without altering the audited tree.

Prepared draft description only. No branch publication, commit or PR creation is authorized by this preparation.

Publication note (October 19, 2026): Separate authorization now permits publication of this draft PR; the preparation-only statement above records the earlier preparation boundary.

Blocker #1 application-security audit: PASS
Production deployment: NOT APPROVED

Operational limitations retained for this published review:

Legacy local discovery and summary refresh are retired in both Hub and non-Hub modes.
No supported public miner IP-rebinding workflow has been confirmed.
Native Windows PowerShell 5.1/SYSTEM validation remains outstanding.
Fleet-scale database and deployed-role validation remain outstanding.
Blocker #3 physical-device identity binding remains incomplete.
Existing old-Agent fencing and upgrade requirements remain applicable.

Legacy discovery, summary refresh and CSV imports could select the wrong inventory record when Zones shared an IP, accept stale telemetry, or bypass control-board replacement authorization. This change binds authenticated Agent discovery, review, enrichment and telemetry to current server Agent/Zone authority and exact inventory identity, with atomic auditing and preserved history. Blocker #1 application-security audit: **PASS**. Production deployment: **NOT APPROVED**. Scope: - Use stable observation IDs/versions, reconcile identity evidence and reject stale ownership or routing. Revalidate enrichment at queue claim and target resolution. Propagate inventory proofs through Windows polling clients and render untrusted Agent Control data as text. - Return HTTP 410 for direct/range discovery, local scheduled/manual known-miner refresh and one/bulk legacy summary writers in both Hub and non-Hub modes, including internal aliases and scheduler callers. Rejection precedes device I/O and mutation. - Keep CSV metadata imports available using exact Miner ID, current MAC, unambiguous serial, or IP plus explicit Zone. Reject conflicting identifiers and ambiguous IP fallback; commit metadata and actor-attributed audit together, with whole-import rollback on denial/audit failure. - Preserve Stage A physical-command containment. Include no migrations, Docker/build-context, schema-compatibility, system-health or unrelated control changes. Independent evidence on this exact tree: - 141 focused PostgreSQL/registered-HTTP tests passed, including real concurrency/lock waits, actual audit privilege-denial rollback, ownership changes, enrichment routing and historical preservation. - Chromium stored-injection/stable-action/retirement-error checks passed. Linux PowerShell 7.4: 12 discovery, 165 containment and 2,444 diagnostic checks passed. - Credential transition/enrollment passed; the full legacy-retirement migration fixture passed, with 8 real-auth passes and 4 intentional case-specific skips. Populated head upgrade preserved all 47 public tables. - Broad source/service suite: 72/74 passed. Both failures reproduce on the unchanged approved baseline; assertions remain unchanged: - `AgentEnrichmentIsolationSourceTests.test_legacy_config_remains_explicitly_legacy_only` - `AgentSourceContractTests.test_deployment_preserves_local_state_and_registers_established_tasks` Operational compatibility and release gates: - Authenticated Agent observation/review and inventory-bound polling replace local discovery/summary refresh. Server-only installations have no local fallback; reachability-only scanning remains. - Automatic/public IP rebinding for an existing miner is unavailable. Changed-IP observations fail closed; a separately authorized address-rebinding workflow is required. - Unsupported old Agent payloads require coordinated upgrades. Native Windows PowerShell 5.1/SYSTEM and mixed-version operation, actual deployed database-role privileges and fleet-scale lock throughput still require release validation. - Verified old-Agent network fencing and stop/drain/upgrade/cutover validation remain required. Cached commands cannot be revoked solely by server cancellation. Physical-device identity binding and Blocker #3 Stages B-E remain outside this change. Review identity and references: - Source: `codex/review-07-discovery-isolation` (proposed); target: `codex/review-06-stage-a-containment`. - Exact parent: `e898f283ab0fc21bac77b63db1c4a9ad35e21562`; tree: `cf863aadc9019aefcdec3ba1dd3880619f4f6561`. - Patch SHA-256: `0d2b2b03ef24c966e1ec633e96b4e8f3c5f37881802c25004f3fa42a012cdc9f`. - Boundary: 26 files, 12 added / 14 modified / 0 deleted; +3,798 / -4,092 lines with minimal or histogram diff. - Independent PASS report on review host: `/tmp/minerops-blocker1-reaudit.83ak6lwx/security-reaudit.txt`; verdict: `/tmp/minerops-blocker1-reaudit.83ak6lwx/verdict.json`. - Corrected patch on review host: `/tmp/minerops-blocker1-remediation.dhgyq25j/blocker-1-review.patch`. - The frozen in-tree review notes predate the subsequent independent PASS; the report and verdict above record the completed re-audit without altering the audited tree. Prepared draft description only. No branch publication, commit or PR creation is authorized by this preparation. Publication note (October 19, 2026): Separate authorization now permits publication of this draft PR; the preparation-only statement above records the earlier preparation boundary. Blocker #1 application-security audit: PASS Production deployment: NOT APPROVED Operational limitations retained for this published review: - Legacy local discovery and summary refresh are retired in both Hub and non-Hub modes. - No supported public miner IP-rebinding workflow has been confirmed. - Native Windows PowerShell 5.1/SYSTEM validation remains outstanding. - Fleet-scale database and deployed-role validation remain outstanding. - Blocker #3 physical-device identity binding remains incomplete. - Existing old-Agent fencing and upgrade requirements remain applicable.

lussierj added 1 commit 2026-10-19 09:41:00 -05:00

security(discovery): enforce Zone isolation and retire unsafe legacy writers 8b0d32cd6b

Bind Agent observations, review, enrichment and telemetry to current Zone
and inventory authority. Preserve immutable MAC ownership and historical
snapshots with stale-result rejection and transactional security audits.

Retire unbound direct/range/scheduled discovery and one/bulk legacy summary
writes in both modes. Require reconciled exact inventory identity or
explicit Zone-scoped IP selection for CSV metadata imports.

Independent Blocker #1 application-security re-audit: PASS on tree
cf863aadc9. Evidence: 141 focused PostgreSQL/HTTP
tests passed; Chromium and PowerShell checks passed. Two documented baseline
source assertions remain unchanged. Production deployment is not approved.

You are not authorized to merge this pull request.

This pull request can be merged automatically.

This pull request is marked as a work in progress.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin codex/review-07-discovery-isolation:codex/review-07-discovery-isolation

git checkout codex/review-07-discovery-isolation

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: lussierj/minerops#7